Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 70 #2222

Merged
merged 6 commits into from
Apr 24, 2020
Merged

Patch 70 #2222

merged 6 commits into from
Apr 24, 2020

Conversation

gmt2001
Copy link
Member

@gmt2001 gmt2001 commented Apr 24, 2020

  • Fix WsSharedRWTokenAuthenticationHandler not authenticating readauth tokens
  • Fix equalsIgnoreCase on undefined and Java vs JS for permissions.getKeyIndex
  • Add handling for attempts to connect to HTTP/WS instead of HTTPS/WSS when SSL is enabled
  • Add better response when attempting to send an authenticated request to an unauthenticated endpoint
  • Fix $.permCom

@BrandenB BrandenB merged commit 20a15c3 into PhantomBot:master Apr 24, 2020
@BrandenB
Copy link
Member

Merging it, but not because I trust these changes.

@gmt2001
Copy link
Member Author

gmt2001 commented Apr 24, 2020

LUL

@gmt2001 gmt2001 deleted the patch-70 branch July 22, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmt2001 @BrandenB